Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz strip html #446

Merged
merged 9 commits into from
Feb 21, 2019
Merged

Quiz strip html #446

merged 9 commits into from
Feb 21, 2019

Conversation

garemoko
Copy link
Contributor

Description
Currently only true/false and multichoice questions strip html code from the question text. This PR applies that approach to all question types.

Related Issues
Fixes #439

PR Type
Fix

@garemoko
Copy link
Contributor Author

Oddly the tests are actually requiring the HTML not to be stripped!

@garemoko
Copy link
Contributor Author

@ryansmith94 this one is ready to review

Copy link
Member

@ryasmi ryasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ryasmi ryasmi merged commit 5853986 into xAPI-vle:master Feb 21, 2019
@HT2Bot
Copy link
Member

HT2Bot commented Feb 21, 2019

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@garemoko garemoko deleted the quiz-strip-html branch February 21, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants